# #################################################################

# Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies).

# All rights reserved.

# 

# Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

# 

# * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

# * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

# * Neither the name of Nokia Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.

# 

# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 

# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 

# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 

# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 

# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.#

#

# readresource.py

#

# Checks : Using ReadResource() instead of ReadResourceL().

#

# Reason : ReadResourceL() should always be used in preference to 

# ReadResource() because in an error scenario ReadResource() 

# effectively fails silently. If no check is performed on the 

# resulting descriptor afterwards, unexpected states can ensue. 

# These states are often characterized by buffer overflows.

#

# #################################################################

script = CScript("readresource")

# matching against a line like this: iCoeEnv->ReadResource( buffer, R_RESOURCE_ID );

script.iReString = r"""

	^\s*				# start of line plus optional whitespace

	\w+					# variable name

	(\.|->)				# "." or "->"

	ReadResource\s*\(.*\)

	\s*;

	"""

script.iFileExts = ["cpp"]

script.iCategory = KCategoryCanPanic

script.iIgnore = KIgnoreCommentsAndQuotes

script.iSeverity = KSeverityHigh

scanner.AddScript(script)