Updated after code review. Modified attribute check for efficiency and hardened OSProcess selection using OSProcess.parseProcess()
authorjohn.dean.3@nokia.com
Tue, 11 Aug 2009 10:31:32 -0500
changeset 403 154ecf9c9186
parent 402 ad8d147e8273
child 405 068dfaa49bcc
Updated after code review. Modified attribute check for efficiency and hardened OSProcess selection using OSProcess.parseProcess()
debuggercdi/com.nokia.cdt.debug.launch/src/com/nokia/cdt/internal/debug/launch/AttachLaunchDelegate.java
--- a/debuggercdi/com.nokia.cdt.debug.launch/src/com/nokia/cdt/internal/debug/launch/AttachLaunchDelegate.java	Mon Aug 10 15:50:55 2009 -0500
+++ b/debuggercdi/com.nokia.cdt.debug.launch/src/com/nokia/cdt/internal/debug/launch/AttachLaunchDelegate.java	Tue Aug 11 10:31:32 2009 -0500
@@ -133,7 +133,7 @@
 								String defaultProcessName = exeFile.getPath().removeFileExtension().lastSegment();
 								OSProcess attachTarget = null;
 								String choosenProcessTarget = config.getAttribute(SettingsData.AttachToProcessDialog_Selection, "");
-								if (!choosenProcessTarget.contentEquals("")) {
+								if (choosenProcessTarget.length() > 0) {
 									attachTarget = chooseProcessTargetNoUI(processesOnTarget, choosenProcessTarget);
 								} else {
 									attachTarget = chooseProcessTarget(processesOnTarget, defaultProcessName);									
@@ -206,7 +206,7 @@
 		attachTarget = null;
 
 		for (OSProcess process : processesOnTarget) {
-			if (process.getName().contains(choosenProcessName)) {
+			if (process.parseProcess().getProcessName().equals(choosenProcessName)) {
 				attachTarget = process;	
 				break;
 			}