1
|
1 |
# #################################################################
|
|
2 |
# Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies).
|
|
3 |
# All rights reserved.
|
|
4 |
#
|
|
5 |
# Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
|
|
6 |
#
|
|
7 |
# * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
|
|
8 |
# * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.
|
|
9 |
# * Neither the name of Nokia Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
|
|
10 |
#
|
|
11 |
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
|
|
12 |
# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS
|
|
13 |
# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
14 |
# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
15 |
# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.#
|
|
16 |
#
|
|
17 |
# multipleinheritance.py
|
|
18 |
#
|
|
19 |
# Checks : Non M-class multiple inheritance.
|
|
20 |
#
|
|
21 |
# Reason : It is bad Symbian OS practice to derive from two classes
|
|
22 |
# that have implemented functions. Complex behaviour that was not
|
|
23 |
# intended can result.
|
|
24 |
#
|
|
25 |
# #################################################################
|
|
26 |
|
|
27 |
script = CScript("multipleinheritance")
|
|
28 |
script.iReString = r"""
|
|
29 |
^\s*
|
|
30 |
class
|
|
31 |
\s+
|
|
32 |
(\w+::)?
|
|
33 |
(\w+)
|
|
34 |
\s*
|
|
35 |
:
|
|
36 |
(.*)"""
|
|
37 |
script.iFileExts = ["h", "cpp"]
|
|
38 |
script.iCategory = KCategoryWrongFunctionality
|
|
39 |
script.iIgnore = KIgnoreCommentsAndQuotes
|
|
40 |
script.iSeverity = KSeverityMedium
|
|
41 |
|
|
42 |
def classcompare(lines, currentline, rematch, filename):
|
|
43 |
m = rematch.search(lines[currentline])
|
|
44 |
if m:
|
|
45 |
className = m.group(2)
|
|
46 |
if className[0] <> "C" or (len(className) == 1) or not className[1].isupper():
|
|
47 |
return 0
|
|
48 |
|
|
49 |
inheritanceString = m.group(3)
|
|
50 |
i = currentline + 1
|
|
51 |
while (inheritanceString.find("{") == -1) and i < len(lines):
|
|
52 |
if (inheritanceString.find(";") <> -1):
|
|
53 |
return 0
|
|
54 |
inheritanceString += lines[i]
|
|
55 |
i += 1
|
|
56 |
|
|
57 |
inheritancelist = inheritanceString.split(",")
|
|
58 |
|
|
59 |
reclass = re.compile("[\s:]*(public|protected|private)?\s*([\w:]+)")
|
|
60 |
classlist = []
|
|
61 |
for inheritance in inheritancelist:
|
|
62 |
match = reclass.search(inheritance)
|
|
63 |
if match:
|
|
64 |
inheritclass = match.group(2)
|
|
65 |
colonpos = inheritclass.rfind(":")
|
|
66 |
if (colonpos <> -1):
|
|
67 |
inheritclass = inheritclass[colonpos + 1:]
|
|
68 |
classlist.append(inheritclass)
|
|
69 |
|
|
70 |
ccount = 0
|
|
71 |
for classname in classlist:
|
|
72 |
if (len(classname) > 2) and classname[0] == "C" and classname[1].isupper():
|
|
73 |
ccount += 1
|
|
74 |
|
|
75 |
if ccount > 1:
|
|
76 |
return 1
|
|
77 |
else:
|
|
78 |
return 0
|
|
79 |
else:
|
|
80 |
return 0
|
|
81 |
|
|
82 |
script.iCompare = classcompare
|
|
83 |
scanner.AddScript(script)
|