srcanamdw/codescanner/scripts/worryingcomments.py
author noe\swadi
Thu, 18 Feb 2010 12:29:02 +0530
changeset 1 22878952f6e2
permissions -rw-r--r--
Committing the CodeScanner Core tool This component has been moved from the StaticAnaApps package. BUG : 5889 (http://developer.symbian.org/webbugs/show_bug.cgi?id=5889).
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     1
# #################################################################
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     2
# Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies).
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     3
# All rights reserved.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     4
# 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     5
# Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     6
# 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     7
# * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     8
# * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     9
# * Neither the name of Nokia Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    10
# 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    11
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    12
# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    13
# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    14
# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    15
# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    16
#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    17
# worryingcomments.py
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    18
#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    19
# Checks : Worrying comments.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    20
#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    21
# Reason : Typically, exclamation and question marks in comments 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    22
# indicate that something odd is in the code or that it is 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    23
# unfinished or not understood fully.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    24
#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    25
# #################################################################
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    26
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    27
script = CScript("worryingcomments")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    28
script.iFileExts = ["h", "cpp", "c"]
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    29
script.iCategory = KCategoryCodeReviewGuides
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    30
script.iIgnore = KIgnoreQuotes
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    31
script.iSeverity = KSeverityLow
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    32
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    33
reWordsStr = r"""\!|\?|[Zz]{3}|kludge|workaround|\scrap|hack"""
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    34
scriptNode = script.ScriptConfig()
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    35
if (scriptNode <> None):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    36
	for wordNode in scriptNode.getElementsByTagName("worryRE"):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    37
		reWordsStr = wordNode.firstChild.nodeValue
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    38
		print "Note: 'worrying comments' pattern configured as: " + reWordsStr
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    39
		break
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    40
script.iReString = r"""
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    41
	/(/|\*)						# "//" or "/*"
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    42
	.*("""+reWordsStr+r""")		# skip to "!", "?", "zzz", "kludge", "workaround", " crap" or "hack"
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    43
	"""
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    44
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    45
def worryingcommentcodecompare(lines, currentline, rematch, filename):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    46
	m = rematch.search(lines[currentline])
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    47
	if m:
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    48
		line = lines[currentline]
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    49
		i = 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    50
		inCommentBlock = 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    51
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    52
		while i < len(line):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    53
			if not inCommentBlock:
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    54
				if (line[i] == "/"):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    55
					if (line[i + 1] == "/"):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    56
						# note i+3 to bypass the character after the start of the comment as can be an in-source documentation directive
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    57
						return (line[i+3:].find("!")<>-1) or (line[i+3:].find("?")<>-1)
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    58
					elif (line[i + 1] == "*"):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    59
						inCommentBlock = 1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    60
						i += 2
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    61
						continue
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    62
			else:
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    63
				endIndex = line[i:].find("*/")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    64
				if (endIndex <> -1):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    65
					inCommentBlock = 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    66
					# note, that first character is ignored in comments as can be direction to the in-source documentation tool
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    67
					if (line[i+1:i + endIndex + 2].find("!") <> -1) or (line[i+1:i + endIndex + 2].find("?") <> -1):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    68
						return 1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    69
					i += endIndex + 2
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    70
					continue
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    71
				else:
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    72
					return 1			
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    73
			i += 1		
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    74
	return 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    75
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    76
script.iCompare = worryingcommentcodecompare
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    77
scanner.AddScript(script)